Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax firebase peer dependency constraint #996

Merged

Conversation

oblador
Copy link
Contributor

@oblador oblador commented Sep 5, 2024

Current peer dependency constraint is several major versions out of sync with latest and cause noisy warnings despite working fine. This PR relaxes them.

@oblador
Copy link
Contributor Author

oblador commented Sep 5, 2024

Related/duplicate: #992

@alanjcharles
Copy link
Contributor

thanks @oblador !

@alanjcharles alanjcharles merged commit a3a947c into segmentio:master Sep 16, 2024
7 checks passed
@oblador
Copy link
Contributor Author

oblador commented Sep 17, 2024

Thanks for merging! Do you mind making a release too? 🙇

@adkenyon
Copy link
Contributor

@alanjcharles do you mind making a release?

@alanjcharles
Copy link
Contributor

🎉 This PR is included in version 2.20.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@oblador
Copy link
Contributor Author

oblador commented Oct 9, 2024

@alanjcharles That's not the same package.

@alanjcharles
Copy link
Contributor

🎉 This PR is included in version 1.3.2 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@oblador
Copy link
Contributor Author

oblador commented Oct 23, 2024

@alanjcharles This also a different package, unrelated to these changes. Could you please release @segment/analytics-react-native-plugin-firebase?

@oblador
Copy link
Contributor Author

oblador commented Oct 23, 2024

cc @bsneed who released it last time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants